Repository navigation
Conversation
* Use named initialization in all zend_module_entry header / trailer macros * Define PHP_CINIT / PHP_CINIT_FUNCTION consistently with other similar macros
Member
Author
kairosci
reviewed
Nov 11, 2026
| #define NO_MODULE_GLOBALS 0, NULL, NULL, NULL | ||
| #define NO_MODULE_GLOBALS \ | ||
| .globals_size = 0, \ | ||
| /* .globals_id_ptr or .globals_ptr = */ NULL, \ |
Contributor
There was a problem hiding this comment.
nit: Could we use a conditional designator here? This leaves one positional initializer in the macros being converted to designated initializers, so it still depends on the struct field order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up GH-24647: