Repository navigation
Conversation
iliaal
reviewed
Nov 10, 2026
Comment on lines
+10
to
+11
| [["attrib" => "a", "modtype" => "x", "values" => ["v"]]], | ||
| [["attrib" => "a", "modtype" => LDAP_MODIFY_BATCH_ADD, "values" => "v"]], |
Member
There was a problem hiding this comment.
These two pass a string, and the old code also reported string given, so they pass without the fix. A non-string value such as 1.5 or null would make them catch it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two type errors of
ldap_modify_batch()(the"modtype"option must be of type int, the"values"option must be of type array) reported the type ofattrib, a string already checked at that point, instead of the type of the rejected value. They now report the type of the value.ldap_modify_batch_programming_error.phptexpected the wrong type for itsstdClassmodtype, so its expected output is updated.To reproduce
Before:
... must be of type int, string givenAfter:
... must be of type int, array given