Repository navigation
Align the Windows OPcache JIT buffer - #25262
Merged
shivammathur merged 2 commits intoNov 12, 2026
Merged
Conversation
shivammathur
force-pushed
the
fix/gh25213-windows-jit-buffer
branch
from
November 9, 2026 15:29
41559b3 to
83d6fc5
Compare
arnaud-lb
approved these changes
Nov 11, 2026
arnaud-lb
left a comment
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
This looks good to me!
Could you add an assertion in zend_jit_startup() or in accel_post_startup() to check that buf is page-aligned?
Member
Author
|
@arnaud-lb I have added the assertion. CI failure is unrelated. |
shivammathur
added a commit
that referenced
this pull request
Nov 12, 2026
* PHP-8.6: Align the Windows OPcache JIT buffer (#25262)
erkia
pushed a commit
to erkia/php-src
that referenced
this pull request
Nov 12, 2026
* PHP-8.4: Align the Windows OPcache JIT buffer (php#25262)
erkia
pushed a commit
to erkia/php-src
that referenced
this pull request
Nov 12, 2026
* PHP-8.5: Align the Windows OPcache JIT buffer (php#25262)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows SHM header is already accounted for by pos. Using the full mapping size keeps the JIT buffer page-aligned and prevents crashes when opcache fills up.
Fixes #25213.