Repository navigation
Conversation
Since b1242c3 a server stream seeded from a session stream shares the parent's SSL_CTX. Two callbacks on that context were registered with the parent's stream as their argument: the ALPN select callback and, on Windows without a CA file, the certificate verify callback. Closing the parent before the child completed its handshake left them reading freed memory, and the child silently negotiated no ALPN protocol. Look up the handshake's own stream from the SSL ex_data, as verify_callback and the SNI callback do, and give the child its own copy of the ALPN protocol list.
bukka
pushed a commit
that referenced
this pull request
Nov 11, 2026
Since b1242c3 a server stream seeded from a session stream shares the parent's SSL_CTX. Two callbacks on that context were registered with the parent's stream as their argument: the ALPN select callback and, on Windows without a CA file, the certificate verify callback. Closing the parent before the child completed its handshake left them reading freed memory, and the child silently negotiated no ALPN protocol. Look up the handshake's own stream from the SSL ex_data, as verify_callback and the SNI callback do, and give the child its own copy of the ALPN protocol list. Closes GH-25211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since b1242c3, a server stream seeded from a session stream shares the parent's
SSL_CTX, whose ALPN select callback (and, on Windows without a CA file, certificate verify callback) was registered with the parent's stream. If the parent is closed before the child's handshake, both read freed memory and the child negotiates no ALPN protocol. Look up the stream from the handshake's SSL instead, and give the child its own copy of the protocol list. Only 8.6 is affected