Repository navigation
tree: use zend_string API when possible - #24330
Merged
Merged
Conversation
github-actions
Bot
added
Category: Engine
Extension: pdo_firebird
Extension: soap
labels
Girgias
force-pushed
the
2026-10-tree-zstr_api
branch
from
October 14, 2026 15:25
059d0df to
7bc2a0b
Compare
Girgias
marked this pull request as ready for review
October 14, 2026 19:11
ndossche
approved these changes
Oct 14, 2026
| *(FB_BOOLEAN*)var->sqldata = (dval != 0) ? FB_TRUE : FB_FALSE; | ||
| break; | ||
| default: | ||
| if (!zend_binary_strncasecmp(Z_STRVAL_P(parameter), Z_STRLEN_P(parameter), "true", 4, 4)) { |
Member
There was a problem hiding this comment.
This is actually a behaviour change: TRUEEEE was previously accepted (unlikely to occur in code), and TRUE too (more likely). Now none of them are accepted anymore. Probably fine.
(Same below)
Though I will note that 1 is accepted as numeric, and TRUE isn't accepted as a boolean; which is weird.
Member
Author
There was a problem hiding this comment.
Right, I mean that's PHP numeric string semantics effectively. 1 is accepted, but TRUE was never accepted. So weird.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.