ext/mbstring: Optimize mb_str_pad() using doubling copies - #23667
Merged
Merged
Conversation
LamentXU123
requested review from
alexdowad and
youkidearitai
as code owners
September 12, 2026 05:51
devnexen
reviewed
Sep 12, 2026
| } | ||
| /* }}} */ | ||
|
|
||
| static char *php_mb_str_pad_fill(char *buffer, zend_string *pad, size_t pad_bytes) |
Member
There was a problem hiding this comment.
nit: I think pad can be const, Gina would probably agrees on it :)
devnexen
approved these changes
Sep 12, 2026
devnexen
left a comment
devnexen
left a comment
Member
There was a problem hiding this comment.
I think it s alright, please wait maintainers review first tough.
Co-Authored-By: David CARLIER <devnexen@gmail.com>
youkidearitai
approved these changes
Sep 12, 2026
youkidearitai
left a comment
youkidearitai
left a comment
Contributor
There was a problem hiding this comment.
I confirmed improve performance when using STR_PAD_BOTH. LGTM.
script
<?php
for ($loop = 0; $loop < 100000; $loop++) {
(mb_str_pad('▶▶', 2000, '❤❓❇', STR_PAD_BOTH));
}
?>
before
real 0m0.270s
user 0m0.234s
sys 0m0.000s
after
real 0m0.053s
user 0m0.047s
sys 0m0.012s
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #23661. Use the same optimization on mb_str_pad.