Repository navigation
Conversation
Sjord
force-pushed
the
curl-move-postredir
branch
from
August 30, 2026 20:51
168fbc3 to
9870cba
Compare
Sjord
marked this pull request as ready for review
August 30, 2026 20:51
Contributor
Author
|
@devnexen Could you take a look at this? |
Contributor
Author
|
@kocsismate Could you take a look at this? |
Member
I think an upgrading note would address this concern. Otherwise LGTM! |
Don't treat CURLOPT_POSTREDIR specially. Just pass its value to curl directly. There is no need to do `& CURL_REDIR_POST_ALL`. Curl already does this internally. The only functional change is that negative numbers will now raise an error, which seems reasonable.
Sjord
force-pushed
the
curl-move-postredir
branch
from
November 11, 2026 21:52
9870cba to
68d08ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't treat CURLOPT_POSTREDIR specially. Just pass its value to curl directly. There is no need to do
& CURL_REDIR_POST_ALL. Curl already does this internally. The only functional change is that negative numbers will now raise an error, which seems reasonable.