ext/session: various refactoring (Feb 2026 #2)#21144
Merged
Girgias merged 4 commits intophp:masterfrom Feb 6, 2026
Merged
Conversation
TimWolla
approved these changes
Feb 5, 2026
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
Optional suggestion. Changes LGTM.
By moving the declaration of the variables inside PS_ENCODE_LOOP() macro.
This deletes the PS_ADD_VARL(), PS_ADD_VAR(), and PS_DEL_VARL() macros.
Girgias
force-pushed
the
2026-02-session-ext-refactoring-2
branch
from
07f5ee8 to
e7c7c64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.