Merged
Conversation
VincentLanglet
force-pushed
the
fix/getParsIterator
branch
from
a7c248c to
deb99ce
Compare
VincentLanglet
requested review from
Girgias,
SakiTakamachi,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
dstogov,
ndossche and
youkidearitai
as code owners
TimWolla
removed
Extension: dba
Extension: dom
Extension: enchant
Extension: exif
Extension: ffi
Extension: fileinfo
Extension: filter
Extension: ftp
Extension: gd
Extension: gettext
Extension: gmp
Extension: hash
Extension: iconv
Extension: json
Extension: ldap
Extension: libxml
Extension: mbstring
Category: Optimizer
ABI break
labels
Member
|
Yes the actual method takes a zend_long so in the stub it should be an int argument indeed. @kocsismate wdyt ? |
Member
|
Same applies here, this is LSP breaking, so I don't think this should target 8.4, but |
Contributor
Author
But in this case, if someone was extending this method, wouldn't already he have an issue with the default value ? |
Member
|
Not if they don't use strict_types. |
VincentLanglet
force-pushed
the
fix/getParsIterator
branch
from
deb99ce to
31a08f3
Compare
Contributor
Author
|
@iluuu1994 I updated the branch/PR to target master. |
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm not familiar with php codebase but I feel like there is an error in definition of getPartsIterator
php-src/ext/intl/breakiterator/breakiterator_iterators.stub.php
Line 9 in 65b4073
Also, I dunno if I have to update this code too
php-src/ext/intl/breakiterator/breakiterator_arginfo.h
Line 41 in 65b4073
See the inconsistency in the doc
https://www.php.net/manual/en/class.intlpartsiterator.php
https://www.php.net/manual/en/intlbreakiterator.getpartsiterator.php