Skip to content

PHP8.3 - Fix for Issue #20792 - #20799

Merged
alexandre-daubois merged 1 commit into
php:PHP-8.3from
sharadraju:PHP-8.3
Dec 29, 2025
Merged

alexandre-daubois merged 1 commit into
php:PHP-8.3from
sharadraju:PHP-8.3

Conversation

@sharadraju

Copy link
Copy Markdown
Contributor

PHP 8.3 rebase for fix for Issue #20792 with run-tests.php

@sharadraju

Copy link
Copy Markdown
Contributor Author

The original PR is #20793.

@alexandre-daubois
alexandre-daubois merged commit 7effcab into php:PHP-8.3 Dec 29, 2025
9 checks passed
alexandre-daubois added a commit that referenced this pull request Dec 29, 2025
* PHP-8.3:
  Fix variable assignment for PHP argument escaping in `run-tests.php` (#20799)
alexandre-daubois added a commit that referenced this pull request Dec 29, 2025
* PHP-8.4:
  Fix variable assignment for PHP argument escaping in `run-tests.php` (#20799)
alexandre-daubois added a commit that referenced this pull request Dec 29, 2025
* PHP-8.5:
  Fix variable assignment for PHP argument escaping in `run-tests.php` (#20799)
@alexandre-daubois

Copy link
Copy Markdown
Member

Thank you @sharadraju!

@iluuu1994

iluuu1994 commented Dec 29, 2025

Copy link
Copy Markdown
Member

@alexandre-daubois Regarding the rebase-issue: I usually use gh pr checkout <num> so I don't have to add many remotes to my cloned repository. You then have your default PHP-x.y branches available for rebasing. You can also do that without gh (https://stackoverflow.com/a/24043923/1320374), but I have a hard time remembering the command.

@alexandre-daubois

Copy link
Copy Markdown
Member

Oh I did not think of rebasing it on my own branches. Of course it would have work. Neat, I'll do this next time. Thank you!

@sharadraju
sharadraju deleted the PHP-8.3 branch December 29, 2025 15:07
@sharadraju

Copy link
Copy Markdown
Contributor Author

Thank you @alexandre-daubois and @iluuu1994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants