Fix for Issue #20792 - #20793
Fix for Issue #20792#20793sharadraju wants to merge 2 commits into
Conversation
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Thank you! This look correct to me. Should be merged for 8.3+ (if merged before the new year, otherwise 8.4+).
|
Hi @sharadraju, I wanted to rebase your PR on 8.3 but unfortunately I cannot do it as your fork doesn't have a PHP-8.3 branch. Don't hesitate to ping me once the rebase is done so we can merge it 🙂 |
|
@alexandre-daubois Thank you for looking into this. I have created the PHP-8.3 branch in my fork and added the change there as well. As for rebasing my PR for PHP-8.3, I will create a new PR based off a fork from the PHP-8.3 branch, if that works for you. I am not able to edit this PR to pick from my forked PHP-8.3 branch. |
|
Ah yes, that's because you used your master as the source branch. Do what's the simplest to you, we'll deal with it 👍 (just mention this PR in the new one to keep track of this) |
|
Thanks @alexandre-daubois . Let me know if it is fine. |
|
Nice, let's wait for the CI to finish then I'll take care of merging it. This one can then be closed. Thanks! |
3 participants
This is a proposed fix for Issue #20792