ext/ldap: [RFC] Deprecate build with Oracle Instance Client version.#19809
ext/ldap: [RFC] Deprecate build with Oracle Instance Client version.#19809devnexen merged 1 commit intophp:masterfrom
Conversation
|
Do not know if I need any more warning in other places. There does not seem any CI for using Oracle Instant Client. |
ext/ldap/ldap.c
Outdated
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| zend_error(E_DEPRECATED, "Calling ldap_connect_wallet is deprecated"); |
There was a problem hiding this comment.
I guess you should consistently use () when referring to a function name. You did so on line 976 but not here.
There was a problem hiding this comment.
Also this should use the #[\Deprecated] attribute in the stub instead of triggering this in C.
devnexen
force-pushed
the
deprecate_oracle_ldap
branch
from
4975330 to
5132197
Compare
devnexen
force-pushed
the
deprecate_oracle_ldap
branch
from
6cd78fc to
3b22db1
Compare
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
RM review, left some notes inline but this is approved, technical review not performed
| GSLC_SSL_NO_UATH | ||
| GSLC_SSL_ONEWAY_UATH | ||
| GSLC_SSL_TWOWAY_UATH | ||
|
|
UPGRADING
Outdated
| ldap_connect with wallet support | ||
| ldap_connect_wallet |
There was a problem hiding this comment.
| ldap_connect with wallet support | |
| ldap_connect_wallet | |
| ldap_connect() with wallet support | |
| ldap_connect_wallet() |
ext/ldap/config.m4
Outdated
| elif test -f $LDAP_LIBDIR/libclntsh.$SHLIB_SUFFIX_NAME.12.1 || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libclntsh.$SHLIB_SUFFIX_NAME.12.1; then | ||
| PHP_ADD_LIBRARY_WITH_PATH([clntsh], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) | ||
| AC_DEFINE([HAVE_ORALDAP], [1]) | ||
| AC_MSG_WARN([Build with Oracle Instant Client is deprecated]) |
There was a problem hiding this comment.
should we include the version of the deprecation here? I'm not familiar with the SOP for deprecations in the build configurations so if that isn't standard no need to include it
There was a problem hiding this comment.
No that s a good point I ll add the version
devnexen
force-pushed
the
deprecate_oracle_ldap
branch
from
3b22db1 to
3efb7f2
Compare
3 participants
No description provided.