Deprecate driver specific PDO methods#19596
Conversation
arnaud-lb
force-pushed
the
pdo-deprecations-methods
branch
from
3044969 to
776cfa2
Compare
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Annoying that we can't just add it to the fake stubs, but this alternative makes sense to me :)
Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
RM approval, technical review not performed
Small question inline in my capacity as someone working with gen_stub, but this is approved regardless
| } | ||
| /* }}} */ | ||
|
|
||
| /* We cannot add #[Deprecated] attributes in @generate-function-entries stubs, |
There was a problem hiding this comment.
oh? Why not? Can you expand no this a bit?
If the support from gen_stub is missing I can try to add it
There was a problem hiding this comment.
I've expanded a bit when replying to @mvorisek above: #19596 (comment)
Possibly we could improve that a little by adding support for attributes to zend_function_entry, expose a function that copies zend_function_entry attributes to a zend_function, and use that in pdo_dbh.c.
5 participants
This implements the "Deprecate driver specific PDO methods" part of https://wiki.php.net/rfc/deprecations_php_8_5.
Constants were handled in #19526.