ext/pdo_pgsql: [RFC] Deprecate PGSQL_TRANSACTION_ constants.#19594
Merged
devnexen merged 1 commit intophp:masterfrom Sep 7, 2025
Merged
ext/pdo_pgsql: [RFC] Deprecate PGSQL_TRANSACTION_ constants.#19594devnexen merged 1 commit intophp:masterfrom
devnexen merged 1 commit intophp:masterfrom
Conversation
17 tasks
Girgias
approved these changes
Sep 3, 2025
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
RM review - code looks good but documentation and tests would be appreciated
DanielEScherzer
approved these changes
Sep 6, 2025
| - PDO_PGSQL: Constants related to transaction states have been deprecated : | ||
| PDO::PGSQL_TRANSACTION_IDLE, PDO::PGSQL_TRANSACTION_ACTIVE, PDO::PGSQL_TRANSACTION_INTRANS, | ||
| PDO::PGSQL_TRANSACTION_INERROR, PDO::PGSQL_TRANSACTION_UNKNOWN. | ||
|
|
Member
There was a problem hiding this comment.
should have a link to the RFC
UPGRADING
Outdated
| PDO::SQLITE_OPEN_CREATE => Pdo\Sqlite::OPEN_CREATE | ||
| RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_driver_specific_pdo_constants_and_methods | ||
|
|
||
| - PDO_PGSQL: Constants related to transaction states have been deprecated : |
Member
There was a problem hiding this comment.
Suggested change
| - PDO_PGSQL: Constants related to transaction states have been deprecated : | |
| - PDO_PGSQL: Constants related to transaction states have been deprecated: |
devnexen
force-pushed
the
pdo_pgsql_rfc_852
branch
from
5fd197b to
f0bcb81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.