Deprecate closure binding issues#19510
Merged
DanielEScherzer merged 1 commit intophp:masterfrom Aug 24, 2025
Merged
Conversation
17 tasks
DanielEScherzer
requested changes
Aug 18, 2025
alexandre-daubois
force-pushed
the
closure-binding-issues
branch
from
ceba643 to
cab66a6
Compare
alexandre-daubois
force-pushed
the
closure-binding-issues
branch
from
cab66a6 to
0c69246
Compare
DanielEScherzer
approved these changes
Aug 20, 2025
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
Looks good to me, will merge tomorrow if there are no objections
alexandre-daubois
force-pushed
the
closure-binding-issues
branch
from
0c69246 to
60cc45b
Compare
DanielEScherzer
force-pushed
the
closure-binding-issues
branch
from
60cc45b to
59fb833
Compare
Member
|
I rebased this and also adjusted the line breaks in the UPGRADING file, will merge once CI passes |
70 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_closure_binding_issues
Part of #19468