ext/pdo_pgsql: Deprecate PDO::PGSQL_TRANSACTION* constants.#19444
Closed
devnexen wants to merge 3 commits intophp:masterfrom
Closed
ext/pdo_pgsql: Deprecate PDO::PGSQL_TRANSACTION* constants.#19444devnexen wants to merge 3 commits intophp:masterfrom
devnexen wants to merge 3 commits intophp:masterfrom
Conversation
Girgias
requested changes
Aug 12, 2025
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
This is missing the global PDO constants that are not on the Pdo\Pgsql class.
devnexen
force-pushed
the
pdo_pgsql_rfc_85
branch
from
dc12c23 to
a2ecf66
Compare
17 tasks
devnexen
force-pushed
the
pdo_pgsql_rfc_85
branch
from
a2ecf66 to
dd5c3ac
Compare
devnexen
force-pushed
the
pdo_pgsql_rfc_85
branch
2 times, most recently
from
7d941da to
303e4b9
Compare
Member
Member
Author
|
Yes feel free to merge as-is no worries :) |
Member
|
I've merged #19526 then. Please note that I haven't touched the |
70 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_pdo_pgsql_constants_related_to_statement_transaction_state