sapi/*/Makefile.frag: install programs built with libtool, with libtool#17633
Open
orlitzky wants to merge 1 commit intophp:PHP-8.4from
Open
sapi/*/Makefile.frag: install programs built with libtool, with libtool#17633orlitzky wants to merge 1 commit intophp:PHP-8.4from
orlitzky wants to merge 1 commit intophp:PHP-8.4from
Conversation
github-actions
bot
added
SAPI: fpm
SAPI: cgi
SAPI: cli
SAPI: litespeed
SAPI: phpdbg
labels
Contributor
Author
|
The CI fail is apparently unrelated, there are similar failures in other PRs, e.g. https://github.com/php/php-src/actions/runs/13055452548/job/36425257936 |
Member
When installing executables that were built using libtool, we are supposed to use $ libtool --mode-install <install-command> rather than the bare <install-command>. This is discussed ever so briefly in the "Installing executables" section of the GNU libtool documentation: https://www.gnu.org/software/libtool/manual/libtool.html So far this has not caused a problem with GNU libtool on the platforms that PHP supports, but there is an alternate libtool implementation called slibtool that stores wrappers at the locations where PHP is expecting the true executables to live. As a result, the wrappers (and not the executables) are installed when slibtool is used to build PHP. This is fixed by replacing, $(INSTALL) with $(LIBTOOL) --mode=install $(INSTALL) in the install-foo rules for the executables that are built with libtool. Closes phpGH-13674
orlitzky
force-pushed
the
slibtool-install
branch
from
c707bc7 to
9f2172d
Compare
orlitzky
requested review from
Girgias,
SakiTakamachi,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
derickr,
devnexen,
dstogov,
kocsismate,
ndossche and
youkidearitai
as code owners
github-actions
bot
added
Extension: exif
Extension: ffi
Extension: fileinfo
Extension: filter
Extension: ftp
Extension: gd
Extension: gettext
Extension: gmp
Extension: hash
Extension: iconv
Extension: json
Extension: ldap
Extension: libxml
Extension: mbstring
Category: Optimizer
ABI break
labels
Contributor
Author
|
I just sat down to fix this, and then I noticed there was a PR linked from the issue, and then I noticed that I was the author of the PR. So I guess let's rebase onto 8.4 now that 8.3 is EOL for bug fixes? |
Member
|
Yes indeed |
ndossche
removed request for
Girgias,
SakiTakamachi,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
devnexen,
dstogov,
kocsismate and
youkidearitai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing executables that were built using libtool, we are supposed to use
rather than the bare
<install-command>. This is discussed ever so briefly in the "Installing executables" section of the GNU libtool documentation .So far this has not caused a problem with GNU libtool on the platforms that PHP supports, but there is an alternate libtool implementation called slibtool that stores wrappers at the locations where PHP is expecting the true executables to live. As a result, the wrappers (and not the executables) are installed when slibtool is used to build PHP.
This is fixed by replacing
$(INSTALL)with$(LIBTOOL) --mode=install $(INSTALL)in the install-foo rules for the executables that are built with libtool.Targeting 8.3 since it's a bugfix, but not a hugely important one. Merging 8.3->master already has a merge conflict, albeit a trivial one.
Closes: