ext/gd: enable avif tests on GH-Actions#15850
Merged
TimWolla merged 1 commit intophp:masterfrom Sep 15, 2024
Merged
Conversation
When the avif support was first added (phpGH-7026), php-src did not use GitHub Actions. When we moved to GitHub Actions for CI, the `--with-avif` option nor the `libavif-dev` dependencies were not added. Cirrus CI still runs the tests, and now that we no longer use Travis CI, this brings parity to test avif on x64 tests on GitHub Actions as well. `libavif-dev` package's x86 builds seem to be missing[^1][^2] on older Ubuntu versions, so this commit only adds it for x64 builds. [^1]: https://packages.ubuntu.com/jammy/libavif-dev [^2]: https://packages.ubuntu.com/noble/libavif-dev
TimWolla
approved these changes
Sep 15, 2024
Member
Author
|
Thank you @TimWolla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the avif support was first added (GH-7026), php-src did not use GitHub Actions. When we moved to GitHub Actions for CI, the
--with-avifoption nor thelibavif-devdependencies were not added.Cirrus CI still runs the tests, and now that we no longer use Travis CI, this brings parity to test avif on x64 tests on GitHub Actions as well.
libavif-devpackage's x86 builds seem to be missing12 on older Ubuntu versions, so this commit only adds it for x64 builds.Footnotes
https://packages.ubuntu.com/jammy/libavif-dev ↩
https://packages.ubuntu.com/noble/libavif-dev ↩