zend_compile.h: ZEND_ACC_DEPRECATED can be used for class constants#15848
Merged
Girgias merged 1 commit intophp:masterfrom Sep 12, 2024
Merged
zend_compile.h: ZEND_ACC_DEPRECATED can be used for class constants#15848Girgias merged 1 commit intophp:masterfrom
ZEND_ACC_DEPRECATED can be used for class constants#15848Girgias merged 1 commit intophp:masterfrom
Conversation
Support for deprecating class constants was added to implement the PHP 8.3 deprecations in php#11615, but the documentation update was missed. [skip ci]
Member
Author
|
CC @Girgias - follow-up to your RFC implementation |
Girgias
approved these changes
Sep 12, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
I don't understand which of my RFCs this is a follow-up, but the change to the comment is correct.
Member
Author
It was a follow-up to #11615 |
Member
|
I had forgotten this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for deprecating class constants was added to implement the PHP 8.3 deprecations in #11615, but the documentation update was missed.
[skip ci]