ext/xml: Deprecate xml_set_object() and passing non-callable strings to handlers#15293
ext/xml: Deprecate xml_set_object() and passing non-callable strings to handlers#15293Girgias merged 5 commits intophp:masterfrom
Conversation
|
On mobile now, but looks like you missed updating some tests, I'll have a look once that's done. |
|
Erg, everything was passing locally |
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Implementation looks fine, only test + wording remarks
ext/xml/tests/xml_set_processing_instruction_handler_basic.phpt
Outdated
Show resolved
Hide resolved
…uld be triggered with other code looking at the bug report
Girgias
force-pushed
the
xml-deprecate-set-object
branch
from
99f0a31 to
d228e38
Compare
|
@Girgias I'm looking at the "Passing non-callable strings to the xml_set_*_handler() functions is now deprecated." part of the deprecation, in particular with respect to this: "This would also mean to unset a handler the value of null must be used instead of an empty string which is also currently allowed. " It looks like there are no tests passing an empty string for the handler. And a quick test run also doesn't show a deprecation notice for an empty string as a callback: https://3v4l.org/AdVej/rfc#vgit.master What am I missing ? |
|
It is producing a deprecation notice locally for me. I am guessing 3v4l.org hasn't pulled the latest master yet. |
|
@Girgias Thanks for clarifying and adding the test. And good point about the |
|
FYI: pinged 3v4l about the master branch being behind (in principle it should update daily, so something has probably broken) |
3 participants
RFC: https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names