Don't miss warning messages

dstogov · dstogov · commit c07a0dbcb9e0 · 2014-09-10T13:02:01.000+04:00
diff --git a/Zend/zend_execute.c b/Zend/zend_execute.c
@@ -636,6 +636,7 @@ static inline int zend_verify_missing_arg_type(zend_function *zf, uint32_t arg_n
 
 		need_msg = zend_verify_arg_class_kind(cur_arg_info, fetch_type, &class_name, &ce TSRMLS_CC);
 		zend_verify_arg_error(E_RECOVERABLE_ERROR, zf, arg_num, need_msg, class_name, "none", "", NULL TSRMLS_CC);
+		return 0;
 	} else if (cur_arg_info->type_hint) {
 		if (cur_arg_info->type_hint == IS_ARRAY) {
 			zend_verify_arg_error(E_RECOVERABLE_ERROR, zf, arg_num, "be of the type array", "", "none", "", NULL TSRMLS_CC);
@@ -646,8 +647,9 @@ static inline int zend_verify_missing_arg_type(zend_function *zf, uint32_t arg_n
 			zend_error(E_ERROR, "Unknown typehint");
 #endif
 		}
+		return 0;
 	}
-	return 0;
+	return 1;
 }
 
 static void zend_verify_missing_arg(zend_execute_data *execute_data, uint32_t arg_num TSRMLS_DC)

Original file line number	Diff line number	Diff line change
`@@ -636,6 +636,7 @@ static inline int zend_verify_missing_arg_type(zend_function *zf, uint32_t arg_n`
`636`	`636`
`637`	`637`	`need_msg = zend_verify_arg_class_kind(cur_arg_info, fetch_type, &class_name, &ce TSRMLS_CC);`
`638`	`638`	`zend_verify_arg_error(E_RECOVERABLE_ERROR, zf, arg_num, need_msg, class_name, "none", "", NULL TSRMLS_CC);`
	`639`	`+ return 0;`
`639`	`640`	`} else if (cur_arg_info->type_hint) {`
`640`	`641`	`if (cur_arg_info->type_hint == IS_ARRAY) {`
`641`	`642`	`zend_verify_arg_error(E_RECOVERABLE_ERROR, zf, arg_num, "be of the type array", "", "none", "", NULL TSRMLS_CC);`
`@@ -646,8 +647,9 @@ static inline int zend_verify_missing_arg_type(zend_function *zf, uint32_t arg_n`
`646`	`647`	`zend_error(E_ERROR, "Unknown typehint");`
`647`	`648`	`#endif`
`648`	`649`	`}`
	`650`	`+ return 0;`
`649`	`651`	`}`
`650`		`- return 0;`
	`652`	`+ return 1;`
`651`	`653`	`}`
`652`	`654`
`653`	`655`	`static void zend_verify_missing_arg(zend_execute_data *execute_data, uint32_t arg_num TSRMLS_DC)`