Try to allow reserved keywords, not working yet

nikic · nikic · commit 902339e2a70a · 2020-06-05T16:32:33.000+02:00
diff --git a/Zend/tests/named_params/reserved.phpt b/Zend/tests/named_params/reserved.phpt
@@ -0,0 +1,17 @@
+--TEST--
+Reserved keywords can be used with named parameters
+--FILE--
+<?php
+
+function test($array) {
+    var_dump($array);
+}
+
+test(array => []);
+
+?>
+--EXPECTF--
+Fatal error: Uncaught Error: Unknown named parameter $=> in %s:%d
+Stack trace:
+#0 {main}
+  thrown in %s on line %d
diff --git a/Zend/zend_language_parser.y b/Zend/zend_language_parser.y
@@ -765,7 +765,7 @@ non_empty_argument_list:
 
 argument:
 		expr				{ $$ = $1; }
-	|	T_STRING T_DOUBLE_ARROW expr
+	|	identifier T_DOUBLE_ARROW expr
 			{ $$ = zend_ast_create(ZEND_AST_NAMED_ARG, $1, $3); }
 	|	T_ELLIPSIS expr	{ $$ = zend_ast_create(ZEND_AST_UNPACK, $2); }
 ;

Original file line number	Diff line number	Diff line change
`@@ -765,7 +765,7 @@ non_empty_argument_list:`
`765`	`765`
`766`	`766`	`argument:`
`767`	`767`	`expr { $$ = $1; }`
`768`		`- \| T_STRING T_DOUBLE_ARROW expr`
	`768`	`+ \| identifier T_DOUBLE_ARROW expr`
`769`	`769`	`{ $$ = zend_ast_create(ZEND_AST_NAMED_ARG, $1, $3); }`
`770`	`770`	`\| T_ELLIPSIS expr { $$ = zend_ast_create(ZEND_AST_UNPACK, $2); }`
`771`	`771`	`;`