Try to allow reserved keywords, not working yet

nikic · nikic · commit 6548411c3e62 · 2020-06-08T13:03:23.000+02:00
diff --git a/Zend/tests/named_params/reserved.phpt b/Zend/tests/named_params/reserved.phpt
@@ -0,0 +1,17 @@
+--TEST--
+Reserved keywords can be used with named parameters
+--FILE--
+<?php
+
+function test($array) {
+    var_dump($array);
+}
+
+test(array => []);
+
+?>
+--EXPECTF--
+Fatal error: Uncaught Error: Unknown named parameter $=> in %s:%d
+Stack trace:
+#0 {main}
+  thrown in %s on line %d
diff --git a/Zend/zend_language_parser.y b/Zend/zend_language_parser.y
@@ -768,7 +768,7 @@ non_empty_argument_list:
 
 argument:
 		expr				{ $$ = $1; }
-	|	T_STRING T_DOUBLE_ARROW expr
+	|	identifier T_DOUBLE_ARROW expr
 			{ $$ = zend_ast_create(ZEND_AST_NAMED_ARG, $1, $3); }
 	|	T_ELLIPSIS expr	{ $$ = zend_ast_create(ZEND_AST_UNPACK, $2); }
 ;

Original file line number	Diff line number	Diff line change
`@@ -768,7 +768,7 @@ non_empty_argument_list:`
`768`	`768`
`769`	`769`	`argument:`
`770`	`770`	`expr { $$ = $1; }`
`771`		`- \| T_STRING T_DOUBLE_ARROW expr`
	`771`	`+ \| identifier T_DOUBLE_ARROW expr`
`772`	`772`	`{ $$ = zend_ast_create(ZEND_AST_NAMED_ARG, $1, $3); }`
`773`	`773`	`\| T_ELLIPSIS expr { $$ = zend_ast_create(ZEND_AST_UNPACK, $2); }`
`774`	`774`	`;`