Update List.java #22
Merged
Update List.java #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Justin, I'm a big fan of your code, but, I think I may have spotted an issue in your add method for ArrayList. When the index of the element that you want to insert is smaller than the size of the list, you shift the array down one spot and insert the value at the desired position. However, I think you forgot to increase the size of the list after that, which may cause some problems when iterating through the arrayList.
Owner
|
That certainly is a bug. Thanks for finding it. I have updated the code and created a unit test for that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the add method for ArrayList, when the index of the element that is inserted is smaller than the size of the list, the algorithm shift the array down one spot and inserts the value at the desired position. However, it does not increases the size of the list after that, which may cause some problems when iterating through the ArrayList.