Repository navigation
Fix flipY on WebGL tilemap tiles moving the tile sideways - #7403
Open
vtxe02023274 wants to merge 1 commit into
Open
vtxe02023274 wants to merge 1 commit into
vtxe02023274 wants to merge 1 commit into
Conversation
The flipY branch of TransformerTile offset x by the frame height instead of y. Fixes phaserjs#7382
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Describe the changes below:
Fixes #7382
TransformerTileoffsetxby the frame height when a tile hadflipY, so a vertically flipped tile on a WebGLTilemapLayerwas drawn off to the side instead of flipped in place. It now offsetsy, the same way theflipXbranch offsetsx. This is the change @shogeki's report points at.The existing unit test expected the old quad (
y + height = -48). It now expects the flipped quad and uses a 32x16 frame so mixing up x and y fails the test.Checked in Chrome with a 3 tile layer (plain,
flipY,flipX+flipY) rendered with WebGL and Canvas and compared pixel by pixel. Before the change the two flipped tiles are drawn in the wrong place on WebGL; after it WebGL matches Canvas.Tiled maps are not affected, their flip flags become
rotation+flipXinParseGID. Onlytile.flipYset from code goes through this branch.