Repository navigation
Round BitmapText glyph vertices according to vertexRoundMode - #7401
Open
vtxe02023274 wants to merge 1 commit into
Open
vtxe02023274 wants to merge 1 commit into
vtxe02023274 wants to merge 1 commit into
Conversation
BitmapText and DynamicBitmapText build their glyph quads directly and skip the transformer nodes, so willRoundVertices was never checked and text at fractional positions rendered blurry even with roundPixels enabled. Fixes phaserjs#7397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Describe the changes below:
BitmapText and DynamicBitmapText build their glyph quads themselves and hand them straight to the submitter, so no transformer node runs and
willRoundVerticeswas never checked. Text at fractional positions stayed blurry even withroundPixels: true, while an Image at the same spot was snapped.This applies the same
#OnlyTranslatecheck the transformers use:BatchChar, which rounds the quad (new optionalroundVerticesarg, so existing callers are unaffected)Tested with the example from the issue at zoom 4 (SwiftShader WebGL). Before, the 4.5 lines are soft. After, BitmapText and DynamicBitmapText at 4.5 are sharp and
setVertexRoundMode('off')still renders unrounded.Added two BatchChar tests for the rounded and unrounded quad.
npm run lintfails to load.eslintrc.jsonwith the installed ESLint 10, so I checked style by hand.Fixes #7397