Fixed hp_execute_internal segfault on 5.6. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is a bit inefficient, because it uses the variables from You could use our fork https://github.com/tideways/php-profiler-extension which adds PHP 5.6 support as well, performance improvements and is generally maintained. You can even use the precompiled binaries/packages for some systems from here: https://tideways.io/profiler/downloads |
hexmode
pushed a commit
to hexmode/xhprof
that referenced
this pull request
Jan 12, 2023
Change version into php_xhprof.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address the issue found in #63.
One approach could be to add an additional if clause for 5.6 and inline 5.6's version of execute_internal. Before doing that, I checked uprofiler to see how/if they'd addressed it and they did more or less what's in the PR here.
It's not clear to me why hp_execute_internal has inlined execute_internal in the past (performance optimization?), but it seems like calling execute_internal directly will be considerably easier to maintain.
This also adds a test from the example in #63.