Reduced dependency on NumPy [skip ci]

ankane · ankane · commit f770ccffe6f2 · 2026-06-02T18:19:42.000-07:00
diff --git a/pgvector/bit.py b/pgvector/bit.py
@@ -11,7 +11,15 @@ def __init__(self, value: bytes | str | list[bool] | np.ndarray[tuple[int], np.d
             data = value
         else:
             if isinstance(value, str):
-                value = [v != '0' for v in value]
+                length = len(value)
+
+                if length % 8 != 0:
+                    value += '0'*(8 - (length % 8))
+
+                try:
+                    data = int(value, 2).to_bytes(len(value) // 8, byteorder='big')
+                except ValueError:
+                    raise ValueError('expected bit string')
             else:
                 value = np.asarray(value)
 
@@ -30,8 +38,8 @@ def __init__(self, value: bytes | str | list[bool] | np.ndarray[tuple[int], np.d
                 if value.ndim != 1:
                     raise ValueError('expected ndim to be 1')
 
-            length = len(value)
-            data = np.packbits(value).tobytes()
+                length = len(value)
+                data = np.packbits(value).tobytes()
 
         self._value = pack('>i', length) + data
 
diff --git a/tests/test_bit.py b/tests/test_bit.py
@@ -19,8 +19,9 @@ def test_str(self):
         assert Bit('101').to_list() == [True, False, True]
 
     def test_str_two(self):
-        # TODO raise
-        assert Bit('201').to_list() == [True, False, True]
+        with pytest.raises(ValueError) as error:
+            Bit('201')
+        assert str(error.value) == 'expected bit string'
 
     def test_bytes(self):
         assert Bit(b'\xff\x00\xf0').to_text() == '111111110000000011110000'
