create/delete FreeRADIUS user (initial commit)#698
Merged
jaredhendrickson13 merged 13 commits intopfrest:next_minorfrom May 20, 2025
Merged
create/delete FreeRADIUS user (initial commit)#698jaredhendrickson13 merged 13 commits intopfrest:next_minorfrom
jaredhendrickson13 merged 13 commits intopfrest:next_minorfrom
Conversation
…y obtains available modules pfrest#681
Bumps [@stoplight/spectral-cli](https://github.com/stoplightio/spectral) from 6.14.3 to 6.15.0. - [Release notes](https://github.com/stoplightio/spectral/releases) - [Changelog](https://github.com/stoplightio/spectral/blob/develop/CHANGELOG.md) - [Commits](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-cli-6.14.3...@stoplight/spectral-cli-6.15.0) --- updated-dependencies: - dependency-name: "@stoplight/spectral-cli" dependency-version: 6.15.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [firebase/php-jwt](https://github.com/firebase/php-jwt) from 6.11.0 to 6.11.1. - [Release notes](https://github.com/firebase/php-jwt/releases) - [Changelog](https://github.com/firebase/php-jwt/blob/main/CHANGELOG.md) - [Commits](firebase/php-jwt@v6.11.0...v6.11.1) --- updated-dependencies: - dependency-name: firebase/php-jwt dependency-version: 6.11.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…and_yarn/master/stoplight/spectral-cli-6.15.0 chore: bump @stoplight/spectral-cli from 6.14.3 to 6.15.0
…oser/master/firebase/php-jwt-6.11.1 chore: bump firebase/php-jwt from 6.11.0 to 6.11.1
This allow to properly set conditions for 'password'
Plural (Many) Endpoint added.
jaredhendrickson13
previously approved these changes
May 20, 2025
Member
jaredhendrickson13
left a comment
There was a problem hiding this comment.
Looks good to me. I'll plan on having this in the next minor release. There is some refactoring going on in that branch for pfSense CE 2.8.0 that may change some aspects of these endpoints but I'll make sure that's taken care of before release.
Thanks for your contribution!
The merge-base changed after approval.
Contributor
Author
|
Hi!
Thanks for this useful API !
I made some changes after initial pull request. Do I need to create new PR ?
…On Tue, 20 May 2025 at 19:04, Jared Hendrickson ***@***.***> wrote:
***@***.**** dismissed review on this pull request.
Looks good to me. I'll plan on having this in the next minor release.
There is some refactoring going on in that branch for pfSense CE 2.8.0 that
may change some aspects of these endpoints but I'll make sure that's taken
care of before release.
Thanks for your contribution!
—
Reply to this email directly, view it on GitHub
<#698 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXK53FCKV4ARTD6ASI3V6M327NG7BAVCNFSM6AAAAAB452W5TKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNJUG44TKNRVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
CU,
Victor Gamov
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
It's my first attempt to extend this very useful API. This initial commit allow to create/delete FreeRADIUS user. Please feel free to make any comments.