-
-
Notifications
You must be signed in to change notification settings - Fork 19
Expand file tree
/
Copy pathSortParserTests.cs
More file actions
415 lines (337 loc) · 14.4 KB
/
Copy pathSortParserTests.cs
File metadata and controls
415 lines (337 loc) · 14.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
namespace QueryKit.UnitTests;
using System.Linq.Expressions;
using Bogus;
using Configuration;
using Exceptions;
using FluentAssertions;
using WebApiTestProject.Entities;
public class SortParserTests
{
[Fact]
public void test_sort_parser_default_sort_direction()
{
// Arrange
var input = "Title";
// Act
var sortExpressions = SortParser.ParseSort<TestingPerson>(input);
// Assert
sortExpressions.Should().HaveCount(1);
var firstSortExpression = sortExpressions[0].Expression!;
var directionOne = sortExpressions[0].IsAscending;
firstSortExpression.Body.Should().BeOfType<UnaryExpression>();
GetMemberName(firstSortExpression).Should().Be("Title");
directionOne.Should().BeTrue();
}
[Fact]
public void test_sort_parser_case_insensitive_sort_direction()
{
// Arrange
var input = "Title ASC, Age DESC";
// Act
var sortExpressions = SortParser.ParseSort<TestingPerson>(input);
// Assert
sortExpressions.Should().HaveCount(2);
var firstSortExpression = sortExpressions[0].Expression!;
var directionOne = sortExpressions[0].IsAscending;
firstSortExpression.Body.Should().BeOfType<UnaryExpression>();
GetMemberName(firstSortExpression).Should().Be("Title");
directionOne.Should().BeTrue();
var secondSortExpression = sortExpressions[1].Expression!;
var directionTwo = sortExpressions[1].IsAscending;
secondSortExpression.Body.Should().BeOfType<UnaryExpression>();
GetMemberName(secondSortExpression).Should().Be("Age");
directionTwo.Should().BeFalse();
}
[Fact]
public void test_sort_parser_empty_input()
{
// Arrange
var input = "";
// Act
var sortExpressions = SortParser.ParseSort<TestingPerson>(input);
// Assert
sortExpressions.Should().BeEmpty();
}
[Fact]
public void test_sort_parser_whitespace_input()
{
// Arrange
var input = " ";
// Act
var sortExpressions = SortParser.ParseSort<TestingPerson>(input);
// Assert
sortExpressions.Should().BeEmpty();
}
[Fact]
public void test_sort_parser_single_property()
{
// Arrange
var input = "Title asc";
// Act
var sortExpressions = SortParser.ParseSort<TestingPerson>(input);
// Assert
sortExpressions.Should().HaveCount(1);
var sortExpression = sortExpressions[0].Expression!;
var directionOne = sortExpressions[0].IsAscending;
sortExpression.Body.Should().BeOfType<UnaryExpression>();
GetMemberName(sortExpression).Should().Be("Title");
directionOne.Should().BeTrue();
}
[Fact]
public void test_sort_parser_multiple_properties()
{
// Arrange
var input = "Title, Age desc";
// Act
var sortExpressions = SortParser.ParseSort<TestingPerson>(input);
// Assert
sortExpressions.Should().HaveCount(2);
var firstSortExpression = sortExpressions[0].Expression!;
var directionOne = sortExpressions[0].IsAscending;
firstSortExpression.Body.Should().BeOfType<UnaryExpression>();
GetMemberName(firstSortExpression).Should().Be("Title");
directionOne.Should().BeTrue();
var secondSortExpression = sortExpressions[1].Expression!;
var directionTwo = sortExpressions[1].IsAscending;
secondSortExpression.Body.Should().BeOfType<UnaryExpression>();
GetMemberName(secondSortExpression).Should().Be("Age");
directionTwo.Should().BeFalse();
}
[Fact]
public void test_sort_parser_multiple_properties_with_minus()
{
// Arrange
var input = "Title, -Age";
// Act
var sortExpressions = SortParser.ParseSort<TestingPerson>(input);
// Assert
sortExpressions.Should().HaveCount(2);
var firstSortExpression = sortExpressions[0].Expression!;
var directionOne = sortExpressions[0].IsAscending;
firstSortExpression.Body.Should().BeOfType<UnaryExpression>();
GetMemberName(firstSortExpression).Should().Be("Title");
directionOne.Should().BeTrue();
var secondSortExpression = sortExpressions[1].Expression!;
var directionTwo = sortExpressions[1].IsAscending;
secondSortExpression.Body.Should().BeOfType<UnaryExpression>();
GetMemberName(secondSortExpression).Should().Be("Age");
directionTwo.Should().BeFalse();
}
[Fact]
public void can_have_no_space_on_comma()
{
// Arrange
var input = "Title,Age desc";
// Act
var sortExpressions = SortParser.ParseSort<TestingPerson>(input);
// Assert
sortExpressions.Should().HaveCount(2);
var firstSortExpression = sortExpressions[0].Expression!;
var directionOne = sortExpressions[0].IsAscending;
firstSortExpression.Body.Should().BeOfType<UnaryExpression>();
GetMemberName(firstSortExpression).Should().Be("Title");
directionOne.Should().BeTrue();
var secondSortExpression = sortExpressions[1].Expression!;
var directionTwo = sortExpressions[1].IsAscending;
secondSortExpression.Body.Should().BeOfType<UnaryExpression>();
GetMemberName(secondSortExpression).Should().Be("Age");
directionTwo.Should().BeFalse();
}
[Fact]
public void can_have_custom_prop_name()
{
var input = "OfficialTitle, Age desc";
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.Title!).HasQueryName("OfficialTitle");
});
var sortExpression = SortParser.ParseSort<TestingPerson>(input, config);
sortExpression.Should().HaveCount(2);
GetMemberName(sortExpression[0].Expression!).Should().Be("Title");
GetMemberName(sortExpression[1].Expression!).Should().Be("Age");
sortExpression[0].IsAscending.Should().BeTrue();
sortExpression[1].IsAscending.Should().BeFalse();
}
[Fact]
public void can_have_custom_child_prop_name()
{
var input = "PhysicalAddress.State";
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.PhysicalAddress.State).HasQueryName("state");
});
var sortExpression = SortParser.ParseSort<TestingPerson>(input, config);
sortExpression.Should().HaveCount(1);
GetMemberName(sortExpression[0].Expression!).Should().Be("PhysicalAddress.State");
sortExpression[0].IsAscending.Should().BeTrue();
}
[Fact]
public void can_have_child_prop_sort()
{
var input = "PhysicalAddress.State";
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.PhysicalAddress.State);
});
var sortExpression = SortParser.ParseSort<TestingPerson>(input, config);
sortExpression.Should().HaveCount(1);
GetMemberName(sortExpression[0].Expression!).Should().Be("PhysicalAddress.State");
sortExpression[0].IsAscending.Should().BeTrue();
}
[Fact]
public void can_prevent_sort_for_custom_prop()
{
var input = "OfficialTitle, Age desc";
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.Title!)
.PreventSort()
.HasQueryName("OfficialTitle");
});
var sortExpression = SortParser.ParseSort<TestingPerson>(input, config);
sortExpression.Should().HaveCount(1);
GetMemberName(sortExpression[0].Expression!).Should().Be("Age");
sortExpression[0].IsAscending.Should().BeFalse();
}
[Fact]
public void can_prevent_sort()
{
var input = "Title, Age desc";
var config = new QueryKitConfiguration(config =>
{
config.Property<TestingPerson>(x => x.Title!)
.PreventSort();
});
var sortExpression = SortParser.ParseSort<TestingPerson>(input, config);
sortExpression.Should().HaveCount(1);
GetMemberName(sortExpression[0].Expression!).Should().Be("Age");
sortExpression[0].IsAscending.Should().BeFalse();
}
[Fact]
public void can_throw_error_when_property_not_recognized()
{
var faker = new Faker();
var propertyName = faker.Lorem.Word();
var input = $"""Title, {propertyName}, Age desc""";
var act = () => SortParser.ParseSort<TestingPerson>(input);
act.Should().Throw<SortParsingException>()
.WithMessage($"Parsing failed during sorting. '{propertyName}' was not recognized.");
}
[Fact]
public void can_throw_error_when_operator_not_recognized()
{
var input = $"""++Title, Age desc""";
var act = () => SortParser.ParseSort<TestingPerson>(input);
act.Should().Throw<SortParsingException>()
.WithMessage($"Parsing failed during sorting. '++Title' was not recognized.");
}
private string GetMemberName<T>(Expression<Func<T, object>>? expr)
{
if (expr == null)
{
throw new ArgumentNullException(nameof(expr));
}
var body = expr.Body;
if (body is UnaryExpression unary)
{
body = unary.Operand;
}
return GetMemberNameFromExpression(body);
}
private string GetMemberNameFromExpression(Expression expr)
{
// Handle conditional expressions (generated by null-safe navigation)
// For x.A == null ? null : x.A.B, we want to extract "A.B"
if (expr is ConditionalExpression conditional)
{
// The IfFalse branch contains the actual property access chain
return GetMemberNameFromExpression(conditional.IfFalse);
}
// Handle Convert expressions that wrap the actual value
if (expr is UnaryExpression { NodeType: ExpressionType.Convert } convertExpr)
{
return GetMemberNameFromExpression(convertExpr.Operand);
}
if (expr is MemberExpression memberExpr)
{
if (memberExpr.Expression?.NodeType == ExpressionType.MemberAccess)
{
return GetMemberNameFromExpression(memberExpr.Expression) + "." + memberExpr.Member.Name;
}
// Check for nested conditional in the expression
if (memberExpr.Expression is ConditionalExpression nestedConditional)
{
var parentName = GetMemberNameFromExpression(nestedConditional);
return parentName + "." + memberExpr.Member.Name;
}
return memberExpr.Member.Name;
}
throw new ArgumentException("Invalid expression type", nameof(expr));
}
#region Nullable Navigation Property Tests
// Test entities for nullable navigation property scenarios
public class Player
{
public string? FirstName { get; set; }
public string? LastName { get; set; }
}
public class MatchPlayer
{
public string? FirstName { get; set; }
public string? LastName { get; set; }
public Player? Player { get; set; } // Nullable navigation property
}
public class PlayerStat
{
public string Id { get; set; } = Guid.NewGuid().ToString();
public int Score { get; set; }
public MatchPlayer MatchPlayer { get; set; } = new();
}
[Fact]
public void in_memory_sort_handles_null_navigation_property_gracefully()
{
// Arrange - Create data where MatchPlayer.Player is null for some items
var stats = new List<PlayerStat>
{
new() { Score = 10, MatchPlayer = new MatchPlayer { FirstName = "Alice", Player = new Player { LastName = "Anderson" } } },
new() { Score = 20, MatchPlayer = new MatchPlayer { FirstName = "Bob", Player = null } }, // null Player!
new() { Score = 30, MatchPlayer = new MatchPlayer { FirstName = "Charlie", Player = new Player { LastName = "Clark" } } },
};
// Act - Sorting by MatchPlayer.Player.LastName should handle null Player gracefully
var sorted = stats.ApplyQueryKitSort("MatchPlayer.Player.LastName asc").ToList();
// Assert - Should not throw, nulls should sort first in ASC order
sorted.Count.Should().Be(3);
// Null values sort first, then alphabetically: null (Bob), Anderson (Alice), Clark (Charlie)
sorted[0].MatchPlayer.FirstName.Should().Be("Bob"); // null Player -> null LastName sorts first
sorted[1].MatchPlayer.FirstName.Should().Be("Alice"); // Anderson
sorted[2].MatchPlayer.FirstName.Should().Be("Charlie"); // Clark
}
[Fact]
public void in_memory_sort_works_with_derived_property_null_handling()
{
// Arrange - The user's workaround uses a derived property with null coalescing
var stats = new List<PlayerStat>
{
new() { Score = 10, MatchPlayer = new MatchPlayer { FirstName = "Alice", LastName = "Direct_A", Player = new Player { LastName = "Anderson" } } },
new() { Score = 20, MatchPlayer = new MatchPlayer { FirstName = "Bob", LastName = "Direct_B", Player = null } }, // null Player - should use MatchPlayer.LastName
new() { Score = 30, MatchPlayer = new MatchPlayer { FirstName = "Charlie", LastName = null, Player = new Player { LastName = "Clark" } } }, // null MatchPlayer.LastName - should use Player.LastName
};
var config = new QueryKitConfiguration(c =>
{
// User's workaround pattern: coalesce MatchPlayer.LastName with Player.LastName
c.DerivedProperty<PlayerStat>(x =>
x.MatchPlayer.LastName ??
(x.MatchPlayer.Player != null ? x.MatchPlayer.Player.LastName : "") ?? "")
.HasQueryName("playerLastName");
});
// Act - Should work without throwing
var sorted = stats.ApplyQueryKitSort("playerLastName asc", config).ToList();
// Assert
sorted.Count.Should().Be(3);
// Order: "Clark", "Direct_A", "Direct_B" (alphabetical by coalesced last name)
sorted[0].MatchPlayer.FirstName.Should().Be("Charlie"); // Clark
sorted[1].MatchPlayer.FirstName.Should().Be("Alice"); // Direct_A
sorted[2].MatchPlayer.FirstName.Should().Be("Bob"); // Direct_B
}
#endregion
}