Skip to content

chore(ExpandableSection): updated indented example for Penta disclosure variation #9894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 3 commits into from
Jan 17, 2024
Merged

chore(ExpandableSection): updated indented example for Penta disclosure variation #9894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52537dd
chore(ExpandableSection): updated indented example for Penta disclosu…
Dec 14, 2023
05ddffa
Added description to indented example
Dec 20, 2023
6cd335a
Added description to disclosure example
Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/ExpandableSection/ExpandableSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ class ExpandableSection extends React.Component<ExpandableSectionProps, Expandab
<AngleRightIcon aria-hidden />
</span>
)}
<span className={css(`${styles.expandableSection}__toggle-text`)}>{toggleContent || computedToggleText}</span>
<span className={css(styles.expandableSectionToggleText)}>{toggleContent || computedToggleText}</span>
</button>
);

Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/ExpandableSection/ExpandableSectionToggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const ExpandableSectionToggle: React.FunctionComponent<ExpandableSectionT
<AngleRightIcon aria-hidden />
</span>
)}
<span className={css(`${styles.expandableSection}__toggle-text`)}>{children}</span>
<span className={css(styles.expandableSectionToggleText)}>{children}</span>
</button>
</div>
);
Expand Down
6 changes: 5 additions & 1 deletion packages/react-core/src/components/ExpandableSection/examples/ExpandableSection.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,15 @@ When passing the `isDetached` property into `<ExpandableSection>`, you must also

### Disclosure variation

You can pass in the `displaySize="lg"` property for a disclosure variation styling.

```ts file="ExpandableSectionDisclosure.tsx"

```

### Indented
### Indented expandable content

You can indent the expandable content by passing in the `isIndented` property. This will not affect the expandable toggle.

```ts file="ExpandableSectionIndented.tsx"

Expand Down
35 changes: 24 additions & 11 deletions packages/react-core/src/components/ExpandableSection/examples/ExpandableSectionIndented.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,34 @@
import React from 'react';
import { ExpandableSection } from '@patternfly/react-core';
import React, { FormEvent } from 'react';
import { ExpandableSection, Checkbox } from '@patternfly/react-core';

export const ExpandableSectionIndented: React.FunctionComponent = () => {
const [isExpanded, setIsExpanded] = React.useState(false);
const [isExpanded, setIsExpanded] = React.useState(true);
const [isDisplayLgChecked, setIsDisplayLgChecked] = React.useState(false);

const onToggle = (_event: React.MouseEvent, isExpanded: boolean) => {
setIsExpanded(isExpanded);
};

const onDisplaySizeCheck = (_event: FormEvent<HTMLInputElement>, checked: boolean) => setIsDisplayLgChecked(checked);

return (
<ExpandableSection
toggleText={isExpanded ? 'Show less' : 'Show more'}
onToggle={onToggle}
isExpanded={isExpanded}
isIndented
>
This content is visible only when the component is expanded.
</ExpandableSection>
<>
<Checkbox
id="displaySize-checkbox"
isChecked={isDisplayLgChecked}
label='displaySize="lg"'
onChange={onDisplaySizeCheck}
/>
<br />
<ExpandableSection
toggleText={isExpanded ? 'Show less' : 'Show more'}
onToggle={onToggle}
isExpanded={isExpanded}
isIndented
displaySize={isDisplayLgChecked ? 'lg' : 'default'}
>
This content is visible only when the component is expanded.
</ExpandableSection>
</>
);
};