docs(tile): Adds content to tile component#9208
docs(tile): Adds content to tile component#9208KaelanKhiatani wants to merge 14 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-9208.surge.sh A11y report: https://patternfly-react-pr-9208-a11y.surge.sh |
KaelanKhiatani
changed the title
|
@KaelanKhiatani looks like some of my previous feedback is still pending - maybe because of our rebase. Can you incorporate that and push an update? You can commit directly from the conversation/comments above, or just make all of the changes locally and add a new commit |
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
There was a problem hiding this comment.
with v5, the "next" components are promoted, so this file is now contained here: https://github.com/patternfly/patternfly-react/blob/main/packages/react-core/src/components/Select/examples/Select.md
This is the link to the v5 page: https://staging.patternfly.org/components/menus/select
In VS code, make sure you're up to date with the 'main' branch and that the Select.md file matches what you see at these links, with the content you're adding. This may be something easier to look at together on a call?
There was a problem hiding this comment.
& content is missing from a few examples, but if you need help drafting that just lmk!
There was a problem hiding this comment.
We can do this tomorrow.
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
|
Closing the PR. The issue will be resolved in PR #9535 |
4 participants
Makes progress on patternfly/patternfly-org#2990
Adds content for tile and select next components.