feat(Dropdown): deprecated old and promoted Next#8835
Conversation
thatblindgeye
changed the title
|
Preview: https://patternfly-react-pr-8835.surge.sh A11y report: https://patternfly-react-pr-8835-a11y.surge.sh |
thatblindgeye
force-pushed
the
iss8072_dropdownDeprecatePromote
branch
from
a8c9023 to
888584c
Compare
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
LGTM!
Just one comment about a pre existing issue with one of the demos.
| const dropdownItems = [ | ||
| <DropdownItem key="link">Link</DropdownItem>, | ||
| <DropdownItem key="action" component="button"> | ||
| <DropdownItemDeprecated key="link">Link</DropdownItemDeprecated>, |
There was a problem hiding this comment.
The dropdown in the toolbar of the Card view demo is not working. That was preexisting to this PR though. probably broke with overflow PR work... We can open a follow up issue.
There was a problem hiding this comment.
I can see whether it's something I can fix as part of the followup to updating usage of deprecated Dropdown to new Dropdown. If it's anything more involved I can open a separate follow up issue.
|
Still reviewing and not a blocker as it wasn't introduced in this PR, but there's a stray comma I noticed in a Dropdown example.
If you have a moment to take that out when you're resolving the merge conflict I'd appreciate it. |
thatblindgeye
force-pushed
the
iss8072_dropdownDeprecatePromote
branch
from
888584c to
0a3507a
Compare
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
As first step for moving to the new PF5/Dropdown component. See patternfly/patternfly-react#8835 and patternfly/patternfly-react#8868 Changes made by https://github.com/patternfly/pf-codemods
As first step for moving to the new PF5/Dropdown component. See patternfly/patternfly-react#8835 and patternfly/patternfly-react#8868 Changes made by https://github.com/patternfly/pf-codemods
Use the new PF/Dropdown and PF/MenuToggle instead. Related to patternfly/patternfly-react#8835 and others.
Use the new PF/Dropdown and PF/MenuToggle instead. Related to patternfly/patternfly-react#8835 and others.
5 participants
What: Closes #8072
Created a followup for updating deprecated usage: #8839
Pages in the preview that would be affected by this PR.
Examples:
Demos:
Additional issues: