refactor(Helper Text): Convert helper text examples to typescript#7488
Merged
tlabaj merged 2 commits intopatternfly:mainfrom Jun 7, 2022
Merged
refactor(Helper Text): Convert helper text examples to typescript#7488tlabaj merged 2 commits intopatternfly:mainfrom
tlabaj merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7488.surge.sh A11y report: https://patternfly-react-pr-7488-a11y.surge.sh |
thatblindgeye
requested changes
Jun 1, 2022
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
For the file names, the full component name could be used I think, e.g. HelperTextDynamic.tsx. Similar to the comment in the Hint PR, within the examples the exported component names could also match the file names to follow the convention used in other conversions.
thatblindgeye
approved these changes
Jun 2, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7481