fix(console): remove files field. this pattern prevents other dist fi… #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les from releasing. affects: @patternfly/react-console
jeff-phillips-18
previously approved these changes
May 14, 2018
Pull Request Test Coverage Report for Build 1349
💛 - Coveralls |
Member
Author
|
both |
Member
Author
|
ok - after further review... it looks like the convention being followed in most monorepos now is to use I'm OK with this convention if others are. I've updated the PR to reflect that and tested it in my fork's build. Seems to be OK 👍 |
cdcabrera
approved these changes
May 14, 2018
jeff-phillips-18
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove files field. this pattern prevents other
distfiles from releasing.affects:
@patternfly/react-consoleWhat:
the
filesglob should not needed anymore. we can simply use npmignore/gitignore from the root like other monorepo packages.I've confirmed this fix resolves the issue noted in #337 in my fork. All dist files should publish.
Link to Storybook:
Additional issues:
Closes #337