build(babelrc): Export ES modules in addition to commonJS #291
Conversation
Pull Request Test Coverage Report for Build 1085
💛 - Coveralls |
dmiller9911
force-pushed
the
build-ExportESModules
branch
2 times, most recently
from
15d3d93 to
9f31986
Compare
Added .babelrcjs to be used by .babelrc. Added script to build components with ES modules and output to dist/esm. Added modules property in package.json to point to new esm directory.
dmiller9911
force-pushed
the
build-ExportESModules
branch
from
9f31986 to
6084edf
Compare
| "commit": "git-cz", | ||
| "build": "npm run build:scripts && npm run build:sass && npm run build:less", | ||
| "build:scripts": "babel src --out-dir dist/js --ignore .test.js,__mocks__", | ||
| "build:scripts": "concurrently \"npm run build:cjs\" \"npm run build:esm\"", |
|
this is great 👏 can you add support for it looks like we will have full ESM module support in NodeJS very soon as well? it would also be fun to experiment w/ configless webpack / |
|
conflicts in package.json now... should we wait for the monorepo to introduce this now? I'm fine either way...no rush here. |
|
Ummmmm. Honestly might as well. Going to close it in favor of that. If monorepo gets pushed too far out we can revisit this. |
4 participants
What:
Now exporting ES Modules in addition to the CommonJS modules we currently export. This does not currently fix treeshaking for webpack 3, but it puts us on the right track. Since we use
export *syntax at the base webpack cannot treeshake this project, I added sideEffects fals to the project.json. This will allow any consumer that is using webpack 4 to treeshake patternfly-react.Link to Storybook:
N/A
Additional issues:
N/A