style(default-name): Added import-default-name eslint rule#286
Merged
jeff-phillips-18 merged 1 commit intopatternfly:masterfrom Apr 2, 2018
Merged
Conversation
dmiller9911
changed the title
Pull Request Test Coverage Report for Build 1044
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1063
💛 - Coveralls |
Member
|
this is a wonderful first contribution @dmiller9911 👏 👏 👏 ... it's nice that this also works automagically with One minor request and I think this is a 🍏 ... can you use something like |
Added a rule to force the naming of the default import specified packages. This will fix inconsistencies with variable names.
dmiller9911
force-pushed
the
Lint-ImportDefaultName
branch
from
7e4aa8a to
2ec3ff6
Compare
dmiller9911
changed the title
priley86
approved these changes
Mar 30, 2018
jeff-phillips-18
approved these changes
Apr 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a rule to force the naming of the default import specified packages. This will fix
inconsistencies with variable names.
What:
Eslint rule for default imports
Link to Storybook:
N/A
Additional issues:
Piggybacks off of PR: #274