refactor: Updated how classNames package is referenced #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 966
💛 - Coveralls |
Pull Request Test Coverage Report for Build 992
💛 - Coveralls |
Member
|
greetings @chalettu and welcome to the pf-react community ✌️ this is very much appreciated! I think standards like this make the code much more readable and easier to follow for all of us (beginners especially). the changes here look great! two more small more requests for this PR to close the issue:
|
Made it consistent across the project how classNames package is imported and used by all components Fix patternfly#230
Contributor
Author
|
@priley86 , I made the updates you requested. Can you take a look at this PR again? Thank you |
priley86
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it consistent across the project how classNames package is imported and used by all components
Fix #230