Docs(storybook): update to storybook 3.4 #269
Conversation
Pull Request Test Coverage Report for Build 1087
💛 - Coveralls |
|
AWESOME!! In support of future upgrade(ability?) might be a good idea to get ahead of the impending |
|
was thinking this exact same thing...@AllenBW... somehow you read my mind... telapathic skills you have ... do you want to shepherd this PR for us (and watch out for the release and do any additional upgrade prep)? Happy to hand this one over :) |
|
@priley86 musta been cuz we met that max threshold for meeting mind meld 😆 (LOVE DA PIC) oh heck yeah, am an expert replace all'er 😏 will tack that work to this one outstanding |
|
whoaaa another big win i just saw after reverting my branch to current 3.2... 3.4 loads noticeably faster!! ⭐️ |
|
gosh the PRESSURE OK OK OK its almost done, just gotta... do the things... almost there... should have this branch repushed by eod 😆 😋 🍭 💃 |
|
@AllenBW You're hilarious :) Enjoying this convo here. |
|
@priley86 would update the storybook... but since #254 is out there... and I'm using it... 😭 Oh so yeah, refactored all uses of EDIT its gotta be said, nothing really changes, saul kinda stays the same cept that nasty depreciation warning is 👋 |
|
Hmm if this one is gonna sit, will hold off on resolving conflicts till its ready to move 👍 |
|
they released |
|
OH yeah yeah yeah hah, of course, official release 🤦♂️ apologies 😏 |
AllenBW
force-pushed
the
storybook-3-4
branch
2 times, most recently
from
9bf6b5e to
892b60d
Compare
😏 😆 Updated original pr note to include this storybook version deployed... Also resolved commit conflicts, updated |
|
looks great 👍 i'm OK to merge this early if others are... it looks like the only thing remaining is an issue w/ storyshots which we don't currently use. |
|
I can't approve this since it's technically my PR still ;) ... but i'm good to merge when others are... |
|
@priley86 yer in luck, they updated to 3.4! pr has been updated to reflect that change |
AllenBW
changed the title
|
looks good! |
6 participants
What:
So I saw this announcement yesterday.... and I just had to try it out...
https://medium.com/storybookjs/storybook-3-4-early-access-964dee3d978e
It looks like our previous issues w/ 3.3 have already been resolved by react-docgen/SB 3.4. There is a few other deprecations living around it would be nice to address in this PR once SB 3.4 releases (soon).
I'm loving the new StorySource and Viewport Addons. Thoughts on adding these in once we upgrade?
Link to Storybook:
Running 3.4 "rc" demo:
https://rawgit.com/priley86/patternfly-react/storybook-3-4-storybook/index.html
Additional issues:
closes #221
Allen Edityah can find the latest of this deployed hereno more storybook for you, its needed elsewhere