Skip to content

Conversation

@aljesusg
Copy link
Contributor

fix #1869

node_modules/@patternfly/react-core/dist/js/components/Accordion/Accordion.d.ts
(2,22): Cannot find module '../../typeUtils'

import { Omit } from '../../typeUtils';

Fix with

import { Omit } from '../../helpers/typeUtils';

@aljesusg
Copy link
Contributor Author

cc @LHinson

@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://1870-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

Codecov Report

Merging #1870 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1870   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         623      623           
  Lines        6870     6870           
  Branches       93       93           
=======================================
  Hits         5676     5676           
  Misses       1154     1154           
  Partials       40       40
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.37% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12dfa0...633e0eb. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Apr 29, 2019

Codecov Report

Merging #1870 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1870   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         623      623           
  Lines        6870     6870           
  Branches       93       93           
=======================================
  Hits         5676     5676           
  Misses       1154     1154           
  Partials       40       40
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.37% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12dfa0...3bdb547. Read the comment docs.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj dlabaj merged commit 780d7c7 into patternfly:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PF4] 3.16.0 not work bug in accordion component

6 participants