Fixes demo to show single and multiple expand behavior #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PatternFly-React preview: https://1860-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #1860 +/- ##
==========================================
- Coverage 82.59% 82.59% -0.01%
==========================================
Files 621 622 +1
Lines 6844 6849 +5
Branches 93 93
==========================================
+ Hits 5653 5657 +4
- Misses 1151 1152 +1
Partials 40 40
Continue to review full report at Codecov.
|
mcoker
previously approved these changes
Apr 26, 2019
kmcfaul
previously approved these changes
Apr 26, 2019
dgutride
previously approved these changes
Apr 26, 2019
Contributor
|
@dlabaj can you get rid of the span that wraps the svg? It's not necessary.
|
Contributor
Author
|
@mcoker sure thing. Doing it now. |
dlabaj
dismissed stale reviews from tlabaj, dgutride, and jessiehuff
via
2ff69e7
mcoker
approved these changes
Apr 26, 2019
dgutride
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the behavior of the accordion for #1387 and makes accordion available to consumers.
Additional issues:
Please merge this PR first #1852 (review) I'll rebase after to get these in.