PatternFly-React preview: https://1852-pr-patternfly-react-patternfly.surge.sh

Codecov Report

Merging #1852 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
- Coverage   82.84%   82.59%   -0.25%     
==========================================
  Files         612      621       +9     
  Lines        6743     6844     +101     
  Branches       82       93      +11     
==========================================
+ Hits         5586     5653      +67     
- Misses       1126     1151      +25     
- Partials       31       40       +9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a47e4e...75f64d0. Read the comment docs.

Not sure if this is already on the list, but we also need to add .pf-m-expanded to the expanded dd, so that there is a blue line to the left of the button/toggle and expanded content, like this

Looks good, @jessiehuff! I just have a couple of minor comments about things to remove.

The section headings that are expand/collapse buttons have aria-label="Details". This attribute should not be there. This overrides the actual heading text that's specified, preventing that text from being announced.

Related to this, the <AccordionToggle> should not have the prop aria-label included.

The examples include aria-label="Primary Content Details" on the <AccordionContent> components. We can keep this as a prop on the component, but to match core we should remove this prop in our examples.

Looks Great Thanks @jessiehuff !

Error in import #1869 we can't upgrade :(

node_modules/@patternfly/react-core/dist/js/components/Accordion/Accordion.d.ts
(2,22): Cannot find module '../../typeUtils'

import { Omit } from '../../typeUtils';

Fix with

import { Omit } from '../../helpers/typeUtils';