feat(DropdownButton): DropdownButton and SplitButton components #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohadlevy
reviewed
Dec 17, 2017
| @@ -0,0 +1 @@ | |||
| export { DropdownButton as default } from 'react-bootstrap'; | |||
Member
There was a problem hiding this comment.
does it make sense to add snapshots? this will ensure markup doesnt change on a newer upgrade of react-bootstrap?
sharvit
force-pushed
the
feature/dropdown-buttons
branch
from
c29e36b to
d84cc9a
Compare
Contributor
Author
|
@ohadlevy - I change it to use the |
jtomasek
suggested changes
Dec 18, 2017
src/components/Button/SplitButton.js
Outdated
|
|
||
| const SplitButton = props => <BsSplitButton {...props} />; | ||
|
|
||
| SplitButton.propTypes = Object.assign(BsSplitButton.propTypes, { |
|
|
||
| DropdownButton.propTypes = Object.assign(BsDropdownButton.propTypes, { | ||
| bsStyle: PropTypes.oneOf(BUTTON_BS_STYLES), | ||
| }); |
Collaborator
There was a problem hiding this comment.
This modifies also the BsDropdownButton.propTypes. To make it correct you either need to use
DropdownButton.propTypes = Object.assign({}, BsDropdownButton.propTypes, {
bsStyle: PropTypes.oneOf(BUTTON_BS_STYLES),
});
or much simpler:
DropdownButton.propTypes = {
...BsDropdownButton.propTypes,
bsStyle: PropTypes.oneOf(BUTTON_BS_STYLES),
});
Member
sharvit
force-pushed
the
feature/dropdown-buttons
branch
from
d84cc9a to
bcc6e12
Compare
Contributor
Author
|
Nice catch @jtomasek! Update all of them in the last commit. |
jtomasek
previously approved these changes
Dec 18, 2017
Contributor
|
Thanks for adding these! They look good to me. :-) |
jeff-phillips-18
previously approved these changes
Dec 18, 2017
Member
|
Can you rebase this PR first @sharvit ? |
Export DropdownButton and SplitButton from react-bootstrap re #11
sharvit
dismissed stale reviews from jeff-phillips-18 and jtomasek
via
9896cdb
sharvit
force-pushed
the
feature/dropdown-buttons
branch
from
bcc6e12 to
9896cdb
Compare
priley86
approved these changes
Dec 19, 2017
jeff-phillips-18
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export DropdownButton and SplitButton from react-bootstrap
re #11
What: