Skip to content

fix(react-drag-drop): support dynamic root element IDs in DragDropCon… #12240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpanroy41 wants to merge 3 commits into
base: main
Choose a base branch
from
+21 −2
Open

fix(react-drag-drop): support dynamic root element IDs in DragDropCon… #12240

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9fc9cc
fix(react-drag-drop): support dynamic root element IDs in DragDropCon…
arpanroy41 Feb 6, 2026
49c785f
perf: memoize root element lookup to avoid repeated DOM queries
arpanroy41 Feb 6, 2026
f4bd4d6
fix(DragDropContainer): handle case when DOM is not available by retu…
arpanroy41 Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions packages/react-drag-drop/src/components/DragDrop/DragDropContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useCallback, useEffect, useRef, useState } from 'react';
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import * as ReactDOM from 'react-dom';
import { css } from '@patternfly/react-styles';
import {
Expand Down Expand Up @@ -288,6 +288,25 @@ export const DragDropContainer: React.FunctionComponent<DragDropContainerProps>
};

const dragOverlay = <DragOverlay>{activeId && getDragOverlay()}</DragOverlay>;

// Find the React root element dynamically instead of hardcoding 'root'
// Memoized to avoid looking up the root element on every render
const rootElement = useMemo(() => {
if (!canUseDOM) {
return null;
}
// Try common root element IDs
const commonRootIds = ['root', 'app', 'main', '__next'];
for (const id of commonRootIds) {
const element = document.getElementById(id);
if (element) {
return element;
}
}
// Fallback to document.body if no common root is found
return document.body;
}, []); // Empty deps - root element doesn't change after mount

return (
<DndContext
sensors={sensors}
Expand All @@ -299,7 +318,7 @@ export const DragDropContainer: React.FunctionComponent<DragDropContainerProps>
{...props}
>
{children}
{canUseDOM ? ReactDOM.createPortal(dragOverlay, document.getElementById('root')) : dragOverlay}
{canUseDOM ? ReactDOM.createPortal(dragOverlay, rootElement) : dragOverlay}
</DndContext>
);
};
Expand Down
Loading