Skip to content

fix: update ToggleGroup examples to properly toggle options #12239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 1 commit into from
Feb 6, 2026
+12 −27
Merged

fix: update ToggleGroup examples to properly toggle options #12239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/react-core/src/components/Alert/examples/AlertAsyncLiveRegion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,7 @@ export const AsyncLiveRegionAlert: React.FunctionComponent = () => {
text="Async alerts on"
buttonId="async-alerts-on"
isSelected={isActive}
onChange={() => setIsActive(true)}
/>
<ToggleGroupItem
text="Async alerts off"
buttonId="async-alerts-off"
isSelected={!isActive}
onChange={() => setIsActive(false)}
onChange={() => setIsActive(!isActive)}
/>
</ToggleGroup>
<AlertGroup hasAnimations isLiveRegion>
Expand Down
3 changes: 2 additions & 1 deletion packages/react-core/src/components/ToggleGroup/examples/ToggleGroupDefaultSingle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ export const ToggleGroupDefaultSingle: React.FunctionComponent = () => {
const [isSelected, setIsSelected] = useState('');
const handleItemClick = (event, _isSelected: boolean) => {
const id = event.currentTarget.id;
setIsSelected(id);
// Allow toggling off if clicking the already selected item
setIsSelected(isSelected === id ? '' : id);
};
return (
<ToggleGroup aria-label="Default with single selectable">
Expand Down
13 changes: 4 additions & 9 deletions packages/react-table/src/components/Table/examples/TableActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ interface Repository {
singleAction: string;
}

type ExampleType = 'defaultToggle' | 'customToggle';
type ExampleType = 'customToggle';

export const TableActions: React.FunctionComponent = () => {
// In real usage, this data would come from some external source like an API via props.
Expand All @@ -45,10 +45,11 @@ export const TableActions: React.FunctionComponent = () => {
};

// This state is just for the ToggleGroup in this example and isn't necessary for Table usage.
const [exampleChoice, setExampleChoice] = useState<ExampleType>('defaultToggle');
const [exampleChoice, setExampleChoice] = useState<ExampleType | ''>('');
const onExampleTypeChange: ToggleGroupItemProps['onChange'] = (event, _isSelected) => {
const id = event.currentTarget.id;
setExampleChoice(id as ExampleType);
// Allow toggling off if clicking the already selected item
setExampleChoice(exampleChoice === id ? '' : (id as ExampleType));
};

const customActionsToggle = (props: CustomActionsToggleProps) => (
Expand Down Expand Up @@ -95,12 +96,6 @@ export const TableActions: React.FunctionComponent = () => {
return (
<Fragment>
<ToggleGroup aria-label="Default uses kebab toggle">
<ToggleGroupItem
text="Default actions toggle"
buttonId="defaultToggle"
isSelected={exampleChoice === 'defaultToggle'}
onChange={onExampleTypeChange}
/>
<ToggleGroupItem
text="Custom actions toggle"
buttonId="customToggle"
Expand Down
15 changes: 5 additions & 10 deletions packages/react-table/src/components/Table/examples/TableBasic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ interface Repository {
lastCommit: string;
}

type ExampleType = 'default' | 'compact' | 'compactBorderless';
type ExampleType = 'compact' | 'compactBorderless';

export const TableBasic: React.FunctionComponent = () => {
// In real usage, this data would come from some external source like an API via props.
Expand All @@ -29,21 +29,16 @@ export const TableBasic: React.FunctionComponent = () => {
};

// This state is just for the ToggleGroup in this example and isn't necessary for Table usage.
const [exampleChoice, setExampleChoice] = useState<ExampleType>('default');
const [exampleChoice, setExampleChoice] = useState<ExampleType | ''>('');
const onExampleTypeChange: ToggleGroupItemProps['onChange'] = (event, _isSelected) => {
const id = event.currentTarget.id;
setExampleChoice(id as ExampleType);
// Allow toggling off if clicking the already selected item
setExampleChoice(exampleChoice === id ? '' : (id as ExampleType));
};

return (
<Fragment>
<ToggleGroup aria-label="Default with single selectable">
<ToggleGroupItem
text="Default"
buttonId="default"
isSelected={exampleChoice === 'default'}
onChange={onExampleTypeChange}
/>
<ToggleGroupItem
text="Compact"
buttonId="compact"
Expand All @@ -59,7 +54,7 @@ export const TableBasic: React.FunctionComponent = () => {
</ToggleGroup>
<Table
aria-label="Simple table"
variant={exampleChoice !== 'default' ? 'compact' : undefined}
variant={exampleChoice === 'compact' || exampleChoice === 'compactBorderless' ? 'compact' : undefined}
borders={exampleChoice !== 'compactBorderless'}
>
<Caption>Simple table using composable components</Caption>
Expand Down
Loading