fix(FileUploadField): don't render empty dom node#12236
Merged
wise-king-sullyman merged 1 commit intopatternfly:mainfrom Feb 5, 2026
Merged
fix(FileUploadField): don't render empty dom node#12236wise-king-sullyman merged 1 commit intopatternfly:mainfrom
wise-king-sullyman merged 1 commit intopatternfly:mainfrom
Conversation
WalkthroughRestructured conditional rendering in FileUploadField component to wrap file details area in a single container that activates when a loading state is active or preview is enabled. The loading spinner and TextArea preview are now rendered together inside this conditional block, consolidating the render flow. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-react-pr-12236.surge.sh A11y report: https://pf-react-pr-12236-a11y.surge.sh |
nicolethoen
approved these changes
Feb 5, 2026
wise-king-sullyman
approved these changes
Feb 5, 2026
Collaborator
|
Change looks great, thanks! |
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #12235
Summary by CodeRabbit