feat(templates): allow react 19#12046
Merged
wise-king-sullyman merged 1 commit intopatternfly:mainfrom Oct 13, 2025
Merged
Conversation
Collaborator
|
Preview: https://pf-react-pr-12046.surge.sh A11y report: https://pf-react-pr-12046-a11y.surge.sh |
rebeccaalpert
approved these changes
Oct 10, 2025
Member
rebeccaalpert
left a comment
There was a problem hiding this comment.
I'm not sure how else to verify, but it does build correctly when I change the React versions in the repo - checked 17, 18, and 19. 18 runs. 19 fails due to docs framework as expected.
17 fails with these - doesn't seem like you though?:
[1] WARNING in ./patternfly-docs/generated/charts/line-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/charts/sankey-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/menus/dropdown/react-templates.js 102:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/menus/select/react-templates.js 162:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/table/react-demos.js 65:2-11
[1] export 'ReactNode' (imported as 'ReactNode') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] webpack 5.94.0 compiled with 5 warnings in 30044 ms
[1] <i> [webpack-dev-middleware] wait until bundle finished: /components/modal
[1] 413 assets
[1] 5587 modules
[1]
[1] WARNING in ./patternfly-docs/generated/charts/line-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/charts/sankey-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/menus/dropdown/react-templates.js 102:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/menus/select/react-templates.js 162:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/table/react-demos.js 65:2-11
[1] export 'ReactNode' (imported as 'ReactNode') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
Contributor
Author
|
Hm might be our docs framework again still. At least, it seems to be more than just the templates that it's complaining about. |
dlabaj
approved these changes
Oct 10, 2025
wise-king-sullyman
approved these changes
Oct 13, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #12014