chore: bump core and docs-framework#12016
Conversation
|
Preview: https://pf-react-pr-12016.surge.sh A11y report: https://pf-react-pr-12016-a11y.surge.sh |
thatblindgeye
left a comment
There was a problem hiding this comment.
From what all was discussed yesterday I think this looks good. One other scenario idk if we want to also try fixing, is if the __header-content container only has the keyboard shortcuts container, the keyboard shortcuts get moved to the left similar to the lanuage tab was doing.
Screenshot and DOM of the "With shortcut menu and main header content" example:
vs removing the controls and header-main containers:
Note this isn't anything to block this PR from merging.
srambach
left a comment
There was a problem hiding this comment.
The changes look good to me and no other issues in a spot check. FWIW, longer term I'd advocate to put a header of some sort on the second and third examples since they are demonstrating height adjustments but they look different because they don't have the header.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Contains core fixes from patternfly/patternfly#7878