Skip to content

chore: bump core#12010

Merged
dlabaj merged 6 commits intopatternfly:mainfrom
mcoker:bump-core-9.17.25
Sep 24, 2025
Merged

chore: bump core#12010
dlabaj merged 6 commits intopatternfly:mainfrom
mcoker:bump-core-9.17.25

Conversation

@mcoker
Copy link
Contributor

@mcoker mcoker commented Sep 17, 2025

No description provided.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Sep 17, 2025 •
edited
Loading

Preview: https://pf-react-pr-12010.surge.sh

A11y report: https://pf-react-pr-12010-a11y.surge.sh

@mcoker
Copy link
Contributor Author

mcoker commented Sep 17, 2025

@nicolethoen or @dlabaj do you know why this is failing? Looks like this is the error

message: 'Module build failed (from ../../node_modules/@patternfly/documentation-framework/node_modules/babel-loader/lib/index.js):\n' +
  "Error: Cannot find package '@babel/preset-env' imported from /home/runner/work/patternfly-react/patternfly-react/packages/react-docs/babel-virtual-resolve-base.js\n" +

FWIW we have @babel/preset-env in core as a devDependency at https://github.com/patternfly/patternfly/blob/ffdfe441ce90c7b4ebd06889ec548075593c98c5/package.json#L48 and under "resolutions" at https://github.com/patternfly/patternfly/blob/ffdfe441ce90c7b4ebd06889ec548075593c98c5/package.json#L105

@mcoker mcoker changed the title chore: bump core and docs-framework chore: bump core Sep 23, 2025
dlabaj
dlabaj reviewed Sep 24, 2025
View reviewed changes
package.json
"devDependencies": {
"@babel/core": "^7.24.7",
"@babel/plugin-transform-modules-commonjs": "^7.24.7",
"@babel/preset-env": "^7.28.3",
Copy link
Contributor

@dlabaj dlabaj Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we have to add this?

Copy link
Contributor Author

@mcoker mcoker Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were getting an error about @babel/preset-env not installed with the core bump. @nicolethoen added it, though I stomped her commit and had to redo it 😇 I believe it's a result of some deps updates in core?

Copy link
Contributor

@dlabaj dlabaj Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay. I missed the convo above.

dlabaj
dlabaj approved these changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj dlabaj merged commit 9f0c9ec into patternfly:main Sep 24, 2025
13 checks passed
@patternfly-build
Copy link
Collaborator

patternfly-build commented Sep 24, 2025

Your changes have been released in:

  • @patternfly/react-charts@8.3.1-prerelease.2
  • @patternfly/react-code-editor@6.3.1-prerelease.18
  • @patternfly/react-core@6.3.1-prerelease.18
  • @patternfly/react-docs@7.3.1-prerelease.22
  • @patternfly/react-drag-drop@6.3.1-prerelease.18
  • @patternfly/react-icons@6.3.1-prerelease.1
  • demo-app-ts@6.0.0-prerelease.156
  • @patternfly/react-styles@6.3.1-prerelease.1
  • @patternfly/react-table@6.3.1-prerelease.20
  • @patternfly/react-templates@6.3.1-prerelease.18
  • @patternfly/react-tokens@6.3.1-prerelease.1

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlabaj dlabaj dlabaj approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcoker @patternfly-build @dlabaj @nicolethoen