fix(MenuItemAction): update to use new favorite button props#11998
Merged
thatblindgeye merged 2 commits intopatternfly:mainfrom Sep 24, 2025
Merged
Conversation
Collaborator
|
Preview: https://pf-react-pr-11998.surge.sh A11y report: https://pf-react-pr-11998-a11y.surge.sh |
thatblindgeye
approved these changes
Sep 12, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
LGTM! Just have a question for core below
wise-king-sullyman
approved these changes
Sep 23, 2025
Comment on lines
51
to
52
| isFavorited !== null && 'pf-m-favorite', | ||
| isFavorited && styles.modifiers.favorited, |
Contributor
There was a problem hiding this comment.
We had a discussion today surrounding this and we should add these classes back in for now since it can technically be breaking. It doesn't look like these classes will interfere with the Button favorite styling. We can open a followup issue to potentially remove these in a breaking change.
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11931